[webkit-reviews] review denied: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 38861] Join the various PluginView destructors into one shared implementation

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Tor Arne Vestbø <vestbo at webkit.org>'s
request for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 38861: Join the various PluginView destructors into one shared
implementation
https://bugs.webkit.org/attachment.cgi?id=38861&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems this could easily be shared in a platformStop() or
destroyPlatformPluginWidget() method:
0 #if defined(XP_WIN)
 261	    DestroyWindow(platformPluginWidget());
 262 #elif defined(XP_MACOSX)
 263	    setPlatformPluginWidget(0);
 264 #elif defined(XP_UNIX) && PLATFORM(QT)
 265	    // TODO: Should this be done for GTK too?
 266	    delete platformPluginWidget();
 267 #endif

r- for the above.