[webkit-reviews] review denied: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 38860] Share PluginView::init() between ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 06:31:43 PDT 2009


Eric Seidel <eric at webkit.org> has denied Tor Arne Vestbø <vestbo at webkit.org>'s
request for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 38860: Share PluginView::init() between ports
https://bugs.webkit.org/attachment.cgi?id=38860&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The return seems unnecessary now:
221	    m_status = PluginStatusCanNotLoadPlugin;
 222	     return false;
 223	 }

This won't compile:
bool PluginView::platformStart()
123123 {
124124	   notImplemented();
125125 }

Otherwise this looks good to me!


More information about the webkit-reviews mailing list