[webkit-reviews] review denied: [Bug 30983] Remove obsolete assertions from CanvasRenderingContext3DMac : [Attachment 42261] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 30983: Remove obsolete assertions from CanvasRenderingContext3DMac
https://bugs.webkit.org/show_bug.cgi?id=30983

Attachment 42261: Patch
https://bugs.webkit.org/attachment.cgi?id=42261&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    ASSERT(program && shader);

We should always use multiple assertions instead of an && in an assertion,
because that way we can tell which one fails.

The title of this bug does not match the patch. The patch does not remove
assertions. It adds assertions and removes unneeded runtime checks.

review- because although the problems with the patch are extremely minor, the
benefit of the patch is also minor

Please fix the title and don't use && in assertions.