[webkit-reviews] review denied: [Bug 23671] PLATFORM(CF) should be set when building for Qt on Darwin : [Attachment 42249] first try.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 23671: PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671

Attachment 42249: first try.
https://bugs.webkit.org/attachment.cgi?id=42249&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -#if PLATFORM(CF)
> +#if PLATFORM(MAC) || PLATFORM(CHROMIUM)
>  #include "LegacyWebArchive.h"
>  #endif

This will change behavior for Chromium builds that are targeting Windows and
Unix, so I think it's incorrect.

I'm not an expert on Chromium ifdefs, but I assume that something along the
lines of:

    #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

Or:

    #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(CF))

would do. Maybe the best way to write it is:

    #if PLATFORM(CF) && (PLATFORM(MAC) || PLATFORM(CHROMIUM))

Otherwise, the patch looks good.