[webkit-reviews] review denied: [Bug 25897] [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries : [Attachment 42052] Remove the extraneous panel

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 25897: [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897

Attachment 42052: Remove the extraneous panel
https://bugs.webkit.org/attachment.cgi?id=42052&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> AccessibilityObjectPlatformInclusion
AccessibilityObject::accessibilityPlatformIncludesObject() const
> {
>+    AccessibilityObject* parent = parentObject();
>+    if (not parent)

Come again?

>+	  return DefaultBehavior;

The only case where this happens is with the WebView itself, right?

>+
>     // When a list item is made up entirely of children (e.g. paragraphs)
>     // the list item gets ignored. We need it.
>-    if (isGroup()) {
>-	  AccessibilityObject* parent = parentObject();
>-	  if (parent && parent->isList())
>-	      return IncludeObject;
>-    }
>+    if (isGroup() && parent->isList())
>+	  return IncludeObject;
>+
>+    // Entries and password fields have extraneous children which we want to
ignore.
>+    if (parent->isPasswordField() || parent->isTextControl())
>+	  return IgnoreObject;
> 
>     return DefaultBehavior;
> }
>-- 
>1.6.3.3
>

Looks good to me otherwise, but r- because of the "not".