[webkit-reviews] review granted: [Bug 30875] Web Inspector: Pull items collections from resources panel and timeline panel into AbstractTimelinePanel. : [Attachment 42049] [PATCH] Pulls collections + does some more unification.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30875: Web Inspector: Pull items collections from resources panel and
timeline panel into AbstractTimelinePanel.
https://bugs.webkit.org/show_bug.cgi?id=30875

Attachment 42049: [PATCH] Pulls collections + does some more unification.
https://bugs.webkit.org/attachment.cgi?id=42049&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +		   // Create the resource tree element and graph.

Mentions resources.


> +	       this._recordStyles[recordTypes.XHRReadyStateChange] = { title:
WebInspector.UIString("XHR Ready State Change"), category:
this.categories.loading };
> +	       this._recordStyles[recordTypes.XHRLoad] = { title:
WebInspector.UIString("XHR Load"), category: this.categories.loading };

I think these should be under scripting not loading, sicne they only wrap the
DOM event call into javascript, not the load.

Once we show resources you will see the XHR resource too as a load bar.