[webkit-reviews] review granted: [Bug 25897] [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries : [Attachment 41950] textcontrolsatk.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 00:26:17 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 25897: [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897

Attachment 41950: textcontrolsatk.diff
https://bugs.webkit.org/attachment.cgi?id=41950&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +static void test_webkit_atk_get_text_at_offset_forms(void)

forms?

> +{
> +    WebKitWebView* webView;
> +    AtkObject *obj;

'*' on the wrong side.

> +    AtkObject *obj;

Same.

Kindly fix before landing. r=me.


More information about the webkit-reviews mailing list