[webkit-reviews] review granted: [Bug 30843] WAI-ARIA: add support for 'option' role : [Attachment 42002] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 30843: WAI-ARIA: add support for 'option' role
https://bugs.webkit.org/show_bug.cgi?id=30843

Attachment 42002: patch
https://bugs.webkit.org/attachment.cgi?id=42002&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Does the test case test the "canHaveChildren = false" aspect of this patch?

By the way, for an override like AccessibilityListBoxOption’s canHaveChildren,
which always returns a constant, I suggest private visibility rather than
public. Anyone who has an AccessibilityListOption* already won't want to call
the function, so it can be private. And anyone who has a pointer to the base
class will still be able to call the function and get the override version.

r=me