[webkit-reviews] review denied: [Bug 30209] Cache::m_liveDecodedResource is not sorted by CachedResource::m_lastDecodedAccessTime : [Attachment 41943] Comment the weaker invariant

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 30209: Cache::m_liveDecodedResource is not sorted by
CachedResource::m_lastDecodedAccessTime
https://bugs.webkit.org/show_bug.cgi?id=30209

Attachment 41943: Comment the weaker invariant
https://bugs.webkit.org/attachment.cgi?id=41943&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good.

> +	   // that the tm_lastDecodedAccessTime is still zero or smaller than

That should be "m_" rather than "tm_".

> +	   // by access time. The weakening of the invariant does not impose
> +	   // a problem. For more details please see:
https://bugs.webkit.org/show_bug.cgi?id=30209

That should be "does not pose a problem" rather than "does not impose a
problem".

As with the last round of review, since this patch is entirely about comments,
I'm holding the comments to a higher than usual standard. review- so you can
fix those two mistakes. Or you can fix them and land -- no need for a formal
review+ in my opinion.