[webkit-reviews] review granted: [Bug 29178] Geolocation should be refactored to use a single map to store all notifiers : [Attachment 41944] Patch 4 for Bug 29178

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 27 10:11:47 PDT 2009


Darin Adler <darin at apple.com> has granted Steve Block <steveblock at google.com>'s
request for review:
Bug 29178: Geolocation should be refactored to use a single map to store all
notifiers
https://bugs.webkit.org/show_bug.cgi?id=29178

Attachment 41944: Patch 4 for Bug 29178
https://bugs.webkit.org/attachment.cgi?id=41944&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

> +    if (iter != m_idToNotifierMap.end()) {
> +	   m_notifierToIdMap.remove(iter->second);
> +	   m_idToNotifierMap.remove(iter);
> +    }

We normally prefer the early exit style, where this would return in the unusual
failure case and the code would continue at the outer nesting level, rather
than nesting the normal code flow path inside an if.


More information about the webkit-reviews mailing list