[webkit-reviews] review requested: [Bug 30823] Fix alpha handling when using wxWidgets 2.9 : [Attachment 41955] Patch fixing alpha transparency handling for wx port

[bugzilla-daemon at webkit.org]

Vadim Zeitlin <vz-webkit at zeitlins.org> has asked  for review:
Bug 30823: Fix alpha handling when using wxWidgets 2.9
https://bugs.webkit.org/show_bug.cgi?id=30823

Attachment 41955: Patch fixing alpha transparency handling for wx port
https://bugs.webkit.org/attachment.cgi?id=41955&action=review

------- Additional Comments from Vadim Zeitlin <vz-webkit at zeitlins.org>
Transparency in PNG images didn't work in wxWebKit because the wxBitmap "has
alpha" internal flag was not set before wxGraphicsBitmap was created from it.
This flag is set in wxPixelData dtor and, generally speaking, bitmap data can't
be accessed at all while it is locked for the raw access via wxPixelData so we
must ensure that the local "data" variable is destroyed before using bitmap in
any way.

This patch does just this: in spite of many apparent changes it simply adds a
block around "data" variable to ensure that it is destroyed (this should be
more clear if the patch is applied and "diff -b" is done).