[webkit-reviews] review denied: [Bug 29425] [Qt] SIGSEGV after WebCore::Frame::loader() : [Attachment 41036] patch v3

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied jedrzej.nowacki at nokia.com's request
for review:
Bug 29425: [Qt] SIGSEGV after WebCore::Frame::loader()
https://bugs.webkit.org/show_bug.cgi?id=29425

Attachment 41036: patch v3
https://bugs.webkit.org/attachment.cgi?id=41036&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good based on my understanding of hos this works.

 180	 RefPtr<Frame> frame(m_originatingProgressFrame);  // Delete
protection.

We prefer RefPtr<Frame> frame = m_originatingProgressFrame;
Also, the comment is unnecessary.

 181	 FrameLoader* loader = frame->loader();  //Shortcut.
 
I wouldn't bother with this short cut.

 183	 loader->client()->willChangeEstimatedProgress();

Why did we add this client callback?