[webkit-reviews] review denied: [Bug 30797] ENABLE_FILTERS compile fixes under Windows : [Attachment 41922] Second rev.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 26 17:49:56 PDT 2009
Darin Adler <darin at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 30797: ENABLE_FILTERS compile fixes under Windows
https://bugs.webkit.org/show_bug.cgi?id=30797
Attachment 41922: Second rev.
https://bugs.webkit.org/attachment.cgi?id=41922&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +#include "MathExtras.h"
The way to include this is:
#include <wtf/MathExtras.h>
> - int dxLeft = static_cast<int>(floor(dx / 2));
> + int dxLeft = static_cast<int>(dx / 2);
You also don't need the static_cast any more.
Please fix the include and consider removing the static_cast. review-
More information about the webkit-reviews
mailing list