[webkit-reviews] review denied: [Bug 30800] Cache recently computed date data : [Attachment 41921] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 26 17:47:29 PDT 2009


Darin Adler <darin at apple.com> has denied Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 30800: Cache recently computed date data
https://bugs.webkit.org/show_bug.cgi?id=30800

Attachment 41921: patch
https://bugs.webkit.org/attachment.cgi?id=41921&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   bool getGregorianDateTime(bool outputIsUTC, WTF::GregorianDateTime&)
const;
> +	   bool getGregorianDateTime(ExecState* exec, bool outputIsUTC,
WTF::GregorianDateTime&) const;

No need for the argument name "exec" here.

You forgot to "svn add" the new files so I could not review them. review-
because this is not a complete patch


More information about the webkit-reviews mailing list