[webkit-reviews] review granted: [Bug 27011] [Gtk] Implement support for get_index_in_parent : [Attachment 41884] getindexinparent.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 27011: [Gtk] Implement support for get_index_in_parent
https://bugs.webkit.org/show_bug.cgi?id=27011

Attachment 41884: getindexinparent.patch
https://bugs.webkit.org/attachment.cgi?id=41884&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>

> +    g_return_val_if_fail (parent, 0);

Space before ( here.

> +    AccessibilityObject::AccessibilityChildrenVector children =
parent->children();
> +    unsigned count = children.size();
> +    for (unsigned k = 0; k < count; ++k) {
> +	   if (children[k] == coreObject)
> +	       return k;
> +    }

k? i sounds more idiomatic ;D also, why not use children.size() directly
instead of creating a variable?

Except for the nits, I see no obvious problem, and trust Joanmarie's judgement.