[webkit-reviews] review granted: [Bug 30424] REGRESSION (r48687): Pages on ucas.com appear blank : [Attachment 41892] Proposed fix and layout test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 30424: REGRESSION (r48687): Pages on ucas.com appear blank
https://bugs.webkit.org/show_bug.cgi?id=30424

Attachment 41892: Proposed fix and layout test
https://bugs.webkit.org/attachment.cgi?id=41892&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // http://webkit.org/b/30424 - Invalid history navigations (such as
history.forward() during a new load) have
> +    // the side effect of cancelling any scheduled redirects. We also avoid
the possibility of cancelling the
> +    // current load by avoiding the scheduled redirection altogether.

I am not a huge fan of including bug URLs in the code. Otherwise, this comment
is fine. I'd just leave out the URL.

> +if (window.layoutTestController)
> +    window.layoutTestController.dumpAsText();

The second line can just say "layoutTestController", not
"window.layoutTestController".

> +http://webkit.org/b/30424 and <rdar://problem/7308952> - REGRESSION (r48687)
- Some pages appear blank.<br>

You need an &lt; here instead of the < sign.