[webkit-reviews] review granted: [Bug 30750] Build improvements for Windows : [Attachment 41797] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 30750: Build improvements for Windows
https://bugs.webkit.org/show_bug.cgi?id=30750

Attachment 41797: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41797&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
If the comments in the change log explained why these are good changes, this
patch would be much better! It could simply say something like "Use winresrc.h
because it exists even when MFC is not installed, and is all that's needed
here." And the equivalent elsewhere.

Or the bug title could be more specific: "Make .rc files compile on Windows
without depending on MFC headers." Then you might be OK without further
comments.

Either of these changes would remove the mysterious "improvements" aspect of
this and make this small simple patch much better!

r=me, as is. Next time, please be clearer in the change log or the bug title or
both.