[webkit-reviews] review denied: [Bug 27147] JS Syntax Highlight is incorrect for keyword followed by string or regexp : [Attachment 41833] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 25 16:57:19 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied  review:
Bug 27147: JS Syntax Highlight is incorrect for keyword followed by string or
regexp
https://bugs.webkit.org/show_bug.cgi?id=27147

Attachment 41833: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41833&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    this.LEXSTATE = {
> +	   INITIAL: 1,
> +	   DIV_ALLOWED: 2,
> +    };
> +    this.CONTINUESTATE = {
> +	   NONE: 0,
> +	   COMMENT: 1,
> +	   SINGLEQUOTESTRING: 2,
> +	   DOUBLEQUOTESTRING: 3,
> +	   REGEXP: 4
> +    };

These should not be all caps. Make them CamelCase.


More information about the webkit-reviews mailing list