[webkit-reviews] review granted: [Bug 30713] Disable ReadWriteLock on platforms using pthreads but which do not support pthread_rwlock : [Attachment 41723] Patch 1 for Bug 30713

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Steve Block <steveblock at google.com>'s
request for review:
Bug 30713: Disable ReadWriteLock on platforms using pthreads but which do not
support pthread_rwlock
https://bugs.webkit.org/show_bug.cgi?id=30713

Attachment 41723: Patch 1 for Bug 30713
https://bugs.webkit.org/attachment.cgi?id=41723&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems OK.

I'm not sure it's good to have all these cases, this one included, where the
type PlatformReadWriteLock defined to be void*. If we're going to omit
ReadWriteLock, then I suggest we do that in the header too rather than
compiling a useless ReadWriteLock.

What's more, I can't find any code using ReadWriteLock anywhere in the WebKit
source code nor in Safari's source code. It looks like Hyatt added this class
but never started using it.

This patch is fine, but I think we could also consider dropping this unused
code.

I see that Mark Rowe said the same thing in his recent comment.