[webkit-reviews] review denied: [Bug 20780] when choosing an auto-completed value in a text input field the javascript 'change' event is not fired. : [Attachment 41629] Patch with manual test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 20780: when choosing an auto-completed value in a text input field the
javascript 'change' event is not fired.
https://bugs.webkit.org/show_bug.cgi?id=20780

Attachment 41629: Patch with manual test
https://bugs.webkit.org/attachment.cgi?id=41629&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
claim that DumpRenderTree cannot emulate autocompletion, but I am not sure this
is true. My reading of Safari's auto-fill code indicates that it works
identically to setting the value attribute from JavaScript would. Can you
reproduce the same problem with code that sets the value in JavaScript? If not,
why not?

I'm definitely not clear on whether this change is always correct for
setInnerTextValue. That's a quite-low-level function used in many different
cases. For example, is this correct for the case where the placeholder is
visible and RenderTextControlMultiLine::updateFromElement calls
setInnerTextValue?

review- and please answer my questions -- it's possible we may be able to land
this patch as is once you do, but I suspect this is not sufficiently researched
and tested

Further, I think the code you are modifying needs a comment. It's not obvious
why m_userEdited should be set to false there and why m_edited should not be.
With a comment we might have a fighting chance of getting it right in the
future.