[webkit-reviews] review requested: [Bug 30660] WebInspector: Can't use IME inside console : [Attachment 41809] proposed patch 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 24 20:45:29 PDT 2009
Keishi Hattori <casey.hattori at gmail.com> has asked for review:
Bug 30660: WebInspector: Can't use IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660
Attachment 41809: proposed patch 4
https://bugs.webkit.org/attachment.cgi?id=41809&action=review
------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
> > - searchField.addEventListener("keydown", this.searchKeyDown.bind(this),
false);
> > - searchField.addEventListener("keyup", this.searchKeyUp.bind(this),
false);
> You only want to unregister keyup.
I removed WebInspector.searchKeyUp because I moved performSearch to
searchKeyDown. Do I need it?
Patch just adds the newline.
More information about the webkit-reviews
mailing list