[webkit-reviews] review denied: [Bug 30660] WebInspector: Can't use IME inside console : [Attachment 41808] proposed patch 3

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 30660: WebInspector: Can't use IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660

Attachment 41808: proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=41808&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> -    searchField.addEventListener("keydown", this.searchKeyDown.bind(this),
false);
> -    searchField.addEventListener("keyup", this.searchKeyUp.bind(this),
false);

You only want to unregister keyup.


> +function isEnterKey(event) {
> +    // Check if in IME.
> +    return event.keyCode !== 229 && event.keyIdentifier === "Enter";
> +}
> \ No newline at end of file

Add a new line.