[webkit-reviews] review denied: [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit : [Attachment 38476] hover-adjacent-v2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yusuke Sato <yusukes at chromium.org>'s
request for review:
Bug 18027: CSS3 Selector Test: combination of hover and multiple chained
sibling selector fails in Webkit
https://bugs.webkit.org/show_bug.cgi?id=18027

Attachment 38476: hover-adjacent-v2
https://bugs.webkit.org/attachment.cgi?id=38476&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
No objections or commentary in the 3 months that this patch has been up for
review.

As far as I can tell, this looks fine to me.

Yusuke, this will cause failure on other platforms since you're only adding Mac
results.

We have 3 options:
1.  Move the results next to the tests instead of in platform/mac.
2.  Add results for other platforms (only necessary if they differ, otherwise
#1 is better).
3.  Make these tests dumpAsText (possible by using getComputedStyle).

If the tests were OK, I would r+ this.