[webkit-reviews] review denied: [Bug 22249] CSS Multicolumn text is split awkwardly : [Attachment 39321] Prevent text inside a multi-column block from being split into columns. (fixed comment)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 12:45:19 PDT 2009


Eric Seidel <eric at webkit.org> has denied Yuta Kitamura <yutak at chromium.org>'s
request for review:
Bug 22249: CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249

Attachment 39321: Prevent text inside a multi-column block from being split
into columns. (fixed comment)
https://bugs.webkit.org/attachment.cgi?id=39321&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
As far as I can tell, this looks fine to me.

Yuta, this will cause failure on other platforms since you're only adding Mac
results.

We have 3 options:
1.  Move the results next to the tests instead of in platform/mac.
2.  Add results for other platforms (only necessary if they differ, otherwise
#1 is better).
3.  Make these tests dumpAsText (possible by using getComputedStyle).

If the tests were OK, I would r+ this.


More information about the webkit-reviews mailing list