[webkit-reviews] review granted: [Bug 29673] In profiler, call tree nodes expansion doesn't respect current sorting : [Attachment 41356] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 15:29:12 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 29673: In profiler, call tree nodes expansion doesn't respect current
sorting
https://bugs.webkit.org/show_bug.cgi?id=29673

Attachment 41356: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41356&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
You should call doPopulate _sharedPopulate. Using an underscore since it is
private.


More information about the webkit-reviews mailing list