[webkit-reviews] review denied: [Bug 30599] V8 binding optimizations (redundant refs, unlikely errors) : [Attachment 41523] patch 1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 30599: V8 binding optimizations (redundant refs, unlikely errors)
https://bugs.webkit.org/show_bug.cgi?id=30599

Attachment 41523: patch 1
https://bugs.webkit.org/attachment.cgi?id=41523&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I don't know that I'll be able to do the final review of this, but I can give
some quick feedback on a part of this.


> Index: WebCore/ChangeLog
> +	   (WebCore::V8DOMWrapper::convertToV8Object): Added overload that
takes a Ref<>
Answering "Why?" is much better than answering "what?" (Answering "What was
done?" is pretty useless because it can be determined by looking at the code.)


Functions shouldn't take a RefPtr. They should take either a PassRefPtr<T> or a
T* (http://webkit.org/coding/RefPtr.html).