[webkit-reviews] review canceled: [Bug 30505] Counters aren't updated when a new counter-increment is added : [Attachment 41401] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 00:52:37 PDT 2009


Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 30505: Counters aren't updated when a new counter-increment is added
https://bugs.webkit.org/show_bug.cgi?id=30505

Attachment 41401: Patch v1
https://bugs.webkit.org/attachment.cgi?id=41401&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
As same as tests of Bug 23262, innerText doesn't output counter values.

I looked how innerText works a bit and found it is not easy to change innerText
to output counter values. innerText uses TextIterator to gather texts and
TextIterator doesn't care about generated contents like counters.

Another idea is adding layoutTestController.dumpCounterNodes(). I think this is
reasonable. I'll file another bug. For now, I remove review? bit.


More information about the webkit-reviews mailing list