[webkit-reviews] review requested: [Bug 29118] StringHash support searching for empty/null strings rather than requiring callers to explicitly check : [Attachment 41487] Proposed patch (rev.2)

[bugzilla-daemon at webkit.org]

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 29118: StringHash support searching for empty/null strings rather than
requiring callers to explicitly check
https://bugs.webkit.org/show_bug.cgi?id=29118

Attachment 41487: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=41487&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
> 1) Benchmarks that show this change doesn't slow us down too much.

What's a good way to have benchmarks of WebKit?

> 2) Examples of crashes that this change fixes.

I couldn't find examples in the existing code.
Comment #3 is the only example.


Anyway, I minimized the patch.
I'll satisfy myself of it :-)