[webkit-reviews] review denied: [Bug 30271] [QT] DRT doesn't support double click simulation : [Attachment 41105] resubmit after adding reset and leapForward

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 19 14:25:35 PDT 2009


Eric Seidel <eric at webkit.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 30271: [QT] DRT doesn't support double click simulation
https://bugs.webkit.org/show_bug.cgi?id=30271

Attachment 41105: resubmit after adding reset and leapForward
https://bugs.webkit.org/attachment.cgi?id=41105&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
m_timeStarted is not a clear variable name.  I don't know what it's supposed to
do.

Why?
+    usleep(ms * 1000);

That seems like a very bad idea.


More information about the webkit-reviews mailing list