[webkit-reviews] review denied: [Bug 30304] struct RGBA32Buffer is twice as big as the old ImageData of Qt : [Attachment 41032] Reduce RGBA32Buffer from 52bytes to 20 bytes per instance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 19 14:22:51 PDT 2009


Eric Seidel <eric at webkit.org> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 30304: struct RGBA32Buffer is twice as big as the old ImageData of Qt
https://bugs.webkit.org/show_bug.cgi?id=30304

Attachment 41032: Reduce RGBA32Buffer from 52bytes to 20 bytes per instance
https://bugs.webkit.org/attachment.cgi?id=41032&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I've never seen WebKit use this style before:
 IntRect& rect = m_rects[frameIndex];
 272	 rect = frameRect;

I think we should either abstract that into a function call where it is OK to
pass a &, or we should use explicit m_rects[frameIndex] = calls.  Or maybe it
would be OK wiht a better variable name than "rect".

I really think pkasting is your best reviewer, even if he's not technically a
reviewer yet.


More information about the webkit-reviews mailing list