[webkit-reviews] review denied: [Bug 18265] @charset rule causes the rest of inline css to be ignored : [Attachment 41306] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 18265: @charset rule causes the rest of inline css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265

Attachment 41306: Patch v1
https://bugs.webkit.org/attachment.cgi?id=41306&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Just a few nitpicks:

> +	   @charset rule causes the rest of inline css to be ignored

You've marked a bug talking about non-inline case as duplicate - could you
please update the title, and add tests for external CSS case?

Is any whitespace allowed by other browsers, or just a single linefeed after
<style>? If it's the latter, perhaps HTML parser should consume the linefeed
instead.

> +++ b/LayoutTests/fast/css/comment-before-charset-expected.txt

How did render tree dumps end up outside platform/mac? They should come with
pixel results - but even better, these tests should be text-only (you can use
getComputedStyle, or check document.styleSheets).

Looks good to me otherwise.