[webkit-reviews] review denied: [Bug 30408] ThreadSpecific instances or ThreadGlobalData instance is being leaked when the WebKit library is being reloaded. : [Attachment 41310] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 16 14:43:56 PDT 2009
Alexey Proskuryakov <ap at webkit.org> has denied Carol Szabo
<carol.szabo at nokia.com>'s request for review:
Bug 30408: ThreadSpecific instances or ThreadGlobalData instance is being
leaked when the WebKit library is being reloaded.
https://bugs.webkit.org/show_bug.cgi?id=30408
Attachment 41310: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=41310&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
If you want to release memory on exit, you need to somehow set an order to
that, ensuring that released objects don't get accessed from destructors of
other objects. In particular, C++ makes no guarantee that "static type&" will
outlive all references to it. ThreadLocalData in particular is very susceptible
to this problem.
This was discussed in much detail on webkit-dev mailing list, and this work is
tracked by bug 27980 (I personally don't expect that to ever be finished, due
to high complexity and relatively low benefit).
I'm going to mark this as a duplicate of bug 27980.
More information about the webkit-reviews
mailing list