[webkit-reviews] review granted: [Bug 30385] [Qt] QGLauncher crashes while closing a window : [Attachment 41224] patch 0.2 + autotests

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 30385: [Qt] QGLauncher crashes while closing a window
https://bugs.webkit.org/show_bug.cgi?id=30385

Attachment 41224: patch 0.2 + autotests
https://bugs.webkit.org/attachment.cgi?id=41224&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Looks good, a few comments to fix when you land:


>  public:
> -    WebPage(QWidget* parent = 0) : QWebPage(parent)
> +    WebPage(QObject* parent = 0) : QWebPage(parent)
>      {

Leave out in this patch, but rs on doing it in a followup.

> +
> +// Task 160192

Cut this

> +/**
> + * Starts an event loop that runs until the given signal is received.
> + Optionally the event loop

And add star here ;)