[webkit-reviews] review denied: [Bug 29896] Runtime configurable WebSocket code is detectable when turned off : [Attachment 40934] WebCore: Enable WebSocket by default if WEB_SOCKETS is enabled at compile time.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 29896: Runtime configurable WebSocket code is detectable when turned off
https://bugs.webkit.org/show_bug.cgi?id=29896

Attachment 40934: WebCore: Enable WebSocket by default if WEB_SOCKETS is
enabled at compile time.
https://bugs.webkit.org/attachment.cgi?id=40934&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Summary: The right fix is to remove change done in
https://bugs.webkit.org/show_bug.cgi?id=28941 and replace it with the mechanism
from https://bugs.webkit.org/show_bug.cgi?id=30240

Details:
The change done in 28941 was to allow for runtime enabling of web sockets, but
it is fundamentally broken because it allows for the feature to be detected
even when it isn't enabled which breaks websites. This patch attempts to repair
28941 by enabling web sockets by default, but it does not address the core
issue that this approach is broken.

There is now a better way to do what is desired:
https://bugs.webkit.org/show_bug.cgi?id=30240

So instead of trying to patch code that will still be broken, it should be
ripped out and replaced with a proper solution.