[webkit-reviews] review denied: [Bug 30268] [Qt] Layouttest fast/css/opacity-float.html failed on Qt : [Attachment 41041] implement setPOSIXLocale

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 30268: [Qt] Layouttest fast/css/opacity-float.html failed on Qt
https://bugs.webkit.org/show_bug.cgi?id=30268

Attachment 41041: implement setPOSIXLocale
https://bugs.webkit.org/attachment.cgi?id=41041&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I think your patch looks good, but I think qt/DumpRenderTree.cpp's
resetToConsistentStateBeforeTesting() should also set the default locale back
(i.e. using QLocale::setDefault).

Could you add that line, just so that we are safe that after a test called
setPOSIXLocale we set this back and avoid side-effects in other tests?