[webkit-reviews] review granted: [Bug 30170] Qt Plugins : Remove usage of winId() : [Attachment 41031] ownerWidget

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 12 22:36:51 PDT 2009


Simon Hausmann <hausmann at webkit.org> has granted Girish Ramakrishnan
<girish at forwardbias.in>'s request for review:
Bug 30170: Qt Plugins : Remove usage of winId()
https://bugs.webkit.org/show_bug.cgi?id=30170

Attachment 41031: ownerWidget
https://bugs.webkit.org/attachment.cgi?id=41031&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Great cleanup!

>      case NPNVnetscapeWindow: {
>	   void* w = reinterpret_cast<void*>(value);
> -	   *((XID *)w) =
m_parentFrame->view()->hostWindow()->platformPageClient()->winId();
> +	   QWebPageClient* client =
m_parentFrame->view()->hostWindow()->platformPageClient();
> +	   *((XID *)w) = client ? client->ownerWidget()->window()->winId() : 0;

>	   return NPERR_NO_ERROR;

I really hope that this works as expected, especially with flash. Where we
previously returned
the windowid of the QWebView here we now return the toplevel ID, which is
according to spec but
may not be what the plugin expects.


More information about the webkit-reviews mailing list