[webkit-reviews] review granted: [Bug 30318] ScriptExecutionContext is not anymore needed to create an EventListener - remove old code. : [Attachment 41076] Proposed fix.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 30318: ScriptExecutionContext is not anymore needed to create an
EventListener - remove old code.
https://bugs.webkit.org/show_bug.cgi?id=30318

Attachment 41076: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=41076&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I see the original change did not remove this code, is there a reason to keep

> it?

I just wanted to keep this potential behavior change separate form other
changes in that patch. Thanks for following up on this!

> it's impossible to create a Node w/o a pointer to Document

That's not entirely accurate; see DOMImplementation::createDocumentType() for
the one and only case when this happens. Maybe you could test for that before
landing (and compare to Firefox), but it's unlikely that there is any harm in
such a change.

r=me