[webkit-reviews] review denied: [Bug 29651] [HTML5] Add a way for an application to register as a protocol handler. : [Attachment 40158] Proposed implementation of window.navigator.registerProtocolHandler and registerContentHandler

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied B. Green <brg at chromium.org>'s request
for review:
Bug 29651: [HTML5] Add a way for an application to register as a protocol
handler.
https://bugs.webkit.org/show_bug.cgi?id=29651

Attachment 40158: Proposed implementation of
window.navigator.registerProtocolHandler and registerContentHandler
https://bugs.webkit.org/attachment.cgi?id=40158&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why are these results platform specific:
LayoutTests/platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.
txt
how many other platforms do we need to update?

This looks fine to me.	The question which is not answered by the ChangeLog is
what spec covers this.	the bug doesn't explain either.  A link to the relevant
section of the spec would be helpful.

We're also not testing this to make sure that it works.  It seems that we could
add this functionality to DumpRenderTree.  Although I guess then we'd just be
testing a mock.

Could we at least have a manual test?

Is this supposed to be completely left up to the client?  Do we allow file://
urls here, should we?  What about data urls?  I'm not sure there is any reason
we should disallow either.

r- due to lack of spec information and the fact that this will cause several
platforms to fail due to platform-specific results.