[webkit-reviews] review requested: [Bug 29551] [Qt] QtWebKit crash with Popups : [Attachment 41035] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 29551: [Qt] QtWebKit crash with Popups
https://bugs.webkit.org/show_bug.cgi?id=29551

Attachment 41035: Patch
https://bugs.webkit.org/attachment.cgi?id=41035&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
This patch disable the deletion of the FormDataIODevide object when the http
backend has finished handling the reply.
The buffers will be deleted a bit later, when the QNetworkReplyImpl is deleted.


The disadvantages I see from this patch is that we are keeping this memory
allocated for a slightly longer time.
Is there any other reason that I may have missed that this object was deleted
on the finish() signal?

Other solutions would be to connect the QNetworkReplyImpl on the destroyed()
signal of the outgoingData member to prevent the dangling pointer.