[webkit-reviews] review requested: [Bug 30286] SVG Gradients can't handle percentage values in userSpaceOnUse mode : [Attachment 41033] linearGradient userSpaceOnUse with percentage

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 30286: SVG Gradients can't handle percentage values in userSpaceOnUse mode
https://bugs.webkit.org/show_bug.cgi?id=30286

Attachment 41033: linearGradient userSpaceOnUse with percentage
https://bugs.webkit.org/attachment.cgi?id=41033&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Some clean up.
The problem was, that we transformed the values x1, ... y2 to doubles, saved
them in LinearGradientAttributes and didn't differ between objectBoundingBox
and userSpaceOnUse later.
I removed LinearGradientAttributes and take the values of
SVGLinearGradientElement directly. We needed LinearGradientAttributes to draw
the gradients on the old platform dependent code of SVGPaintServer. We don't
need it anymore and calculate the box in the element itself.

The same has to be done on radialGradient too. I'll work on it once this code
is landed.

I'll create the test results at home.