[webkit-reviews] review granted: [Bug 30185] Expose origin whitelisting in the WebKit API on Windows : [Attachment 40821] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 7 21:58:38 PDT 2009
Eric Seidel <eric at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 30185: Expose origin whitelisting in the WebKit API on Windows
https://bugs.webkit.org/show_bug.cgi?id=30185
Attachment 40821: Patch v1
https://bugs.webkit.org/attachment.cgi?id=40821&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
rs=me. If you need an in-depth windows review then you should get a windows
person to look at this too, but it looks right as far as I can tell!
looks like you didn't use prepare-ChangeLog --bug 12345
Or maybe you used bugzilla-tool create-bug and that doesn't know how to fix
ChangeLogs yet? Donno.
Obviously the ChangeLogs will need to be fixed, but I assume you plan to commit
this yourself anyway.
More information about the webkit-reviews
mailing list