[webkit-reviews] review granted: [Bug 30193] Move PolicyChecker to it's own file : [Attachment 40842] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 7 22:06:00 PDT 2009
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 30193: Move PolicyChecker to it's own file
https://bugs.webkit.org/show_bug.cgi?id=30193
Attachment 40842: Patch v1
https://bugs.webkit.org/attachment.cgi?id=40842&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Should it really be "PolicyCallback"? and not "NavigationPolicyCallback" or
"LoadPolicyCallback" or "LoaderPolicyCalback"?
Our indent-in-headers policy is under discussion on webkit-dev, but this change
complies to the current style guidelines, so is fine as-is.
cq- given the question about the naming, but otherwise looks fine. You could
reply with some naming justification and set cq+ yourself if you like.
More information about the webkit-reviews
mailing list