[webkit-reviews] review requested: [Bug 30189] Back out StringImpl::m_buffer to make MSVC happy : [Attachment 40830] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 7 17:11:44 PDT 2009


Jens Alfke <snej at chromium.org> has asked  for review:
Bug 30189: Back out StringImpl::m_buffer to make MSVC happy
https://bugs.webkit.org/show_bug.cgi?id=30189

Attachment 40830: patch
https://bugs.webkit.org/attachment.cgi?id=40830&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
It's not worth having the variable-length-array m_buffer in StringImpl if MSVC
doesn't handle it well. So this patch removes it and goes back to the hack of
offsetting the base pointer by sizeof(StringImpl).


More information about the webkit-reviews mailing list