[webkit-reviews] review granted: [Bug 29904] WebKit Mac API should provide a delegate interface for global history (7042773) : [Attachment 40829] Also add the ability to catch title changes

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 29904: WebKit Mac API should provide a delegate interface for global
history (7042773)
https://bugs.webkit.org/show_bug.cgi?id=29904

Attachment 40829: Also add the ability to catch title changes
https://bugs.webkit.org/attachment.cgi?id=40829&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (implementations->setTitleFunc)
> +	       CallHistoryDelegate(implementations->setTitleFunc, view,
@selector(webView:updateHistoryTitle:forURL:), (NSString *)title, (NSString
*)url);
> +    
> +	   return;

I'd probably do early return here instead of nesting the call inside an if.

r=me