[webkit-reviews] review denied: [Bug 30175] [Win] Windows DRT UIDelegate::doDragDrop does not return OLE drag-and-drop return value : [Attachment 40808] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 7 11:53:51 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has denied Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 30175: [Win] Windows DRT UIDelegate::doDragDrop does not return OLE
drag-and-drop return value
https://bugs.webkit.org/show_bug.cgi?id=30175

Attachment 40808: Patch
https://bugs.webkit.org/attachment.cgi?id=40808&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebKit/win/WebCoreSupport/WebDragClient.cpp	(working copy)
> @@ -161,11 +161,9 @@ void WebDragClient::startDrag(DragImageR
>	   if (SUCCEEDED(m_webView->uiDelegate(&ui))) {
>	       COMPtr<IWebUIDelegatePrivate> uiPrivate;
>	       if (SUCCEEDED(ui->QueryInterface(IID_IWebUIDelegatePrivate,
(void**)&uiPrivate)))
> -		   if (SUCCEEDED(uiPrivate->doDragDrop(m_webView,
dataObject.get(), source.get(), okEffect, &effect)))
> -		       return;
> -	   }
> -
> -	   DoDragDrop(dataObject.get(), source.get(), okEffect, &effect);
> +		   uiPrivate->doDragDrop(m_webView, dataObject.get(),
source.get(), okEffect, &effect);
> +	   } else
> +	       DoDragDrop(dataObject.get(), source.get(), okEffect, &effect);

I don't think this change is what we want. This will require that all WebKit
clients that support the IWebUIDelegatePrivate interface implement doDragDrop.
I think we want to leave this code as it was.

> +++ WebKitTools/DumpRenderTree/win/EventSender.h	(working copy)
> @@ -29,13 +29,15 @@
>  #ifndef EventSender_h
>  #define EventSender_h
>  
> +#include <windows.h>

It would be nicer to just forward-declare HRESULT.

The rest of the DRT changes look fine.


More information about the webkit-reviews mailing list