[webkit-reviews] review granted: [Bug 30178] Make the setMetadataURL function foolproof by having it remove user info : [Attachment 40810] patch

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 30178: Make the setMetadataURL function foolproof by having it remove user
info
https://bugs.webkit.org/show_bug.cgi?id=30178

Attachment 40810: patch
https://bugs.webkit.org/attachment.cgi?id=40810&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
> Index: WebKit/mac/Misc/WebNSURLExtras.mm
> ===================================================================
> --- WebKit/mac/Misc/WebNSURLExtras.mm (revision 49253)
> +++ WebKit/mac/Misc/WebNSURLExtras.mm (working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (C) 2005, 2007, 2008 Apple Inc. All rights reserved.
> + * Copyright (C) 2005, 2007, 2008, 2009 Apple Inc. All rights reserved.
>   * Copyright (C) 2006 Alexey Proskuryakov (ap at nypop.com)
>   *
>   * Redistribution and use in source and binary forms, with or without
> @@ -619,17 +619,6 @@ static CFStringRef createStringWithEscap
>      return result;
>  }
>  
> -typedef struct {
> -    NSString *scheme;
> -    NSString *user;
> -    NSString *password;
> -    NSString *host;
> -    CFIndex port; // kCFNotFound means ignore/omit
> -    NSString *path;
> -    NSString *query;
> -    NSString *fragment;
> -} WebKitURLComponents;
> 

I presume this struct is no longer used -- you should mention that in the
ChangeLog.