[webkit-reviews] review granted: [Bug 30132] Make beforeload work with link/xml-stylesheet elements : [Attachment 40743] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 30132: Make beforeload work with link/xml-stylesheet elements
https://bugs.webkit.org/show_bug.cgi?id=30132

Attachment 40743: Patch
https://bugs.webkit.org/attachment.cgi?id=40743&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  void ProcessingInstruction::setData(const String& data, ExceptionCode&)
>  {
> -    int oldLength = m_data.length();
>      m_data = data;
> -    document()->textRemoved(this, 0, oldLength);
> +    checkStyleSheet();
>  }

Why don't we need to call textRemoved anymore? Was it buggy? Is there anything
we need to do for PIs that are not stylesheets? You should address at least
some of these questions in your ChangeLog.

You should add your new test to your ChangeLogs.

r=me