[webkit-reviews] review granted: [Bug 29500] Reduce memory usage of WebCore::StringImpl : [Attachment 40744] patch #5 (remove flag accessors)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jens Alfke <snej at chromium.org>'s
request for review:
Bug 29500: Reduce memory usage of WebCore::StringImpl
https://bugs.webkit.org/show_bug.cgi?id=29500

Attachment 40744: patch #5 (remove flag accessors)
https://bugs.webkit.org/attachment.cgi?id=40744&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // The StringImpl struct and its data may be allocated within a single
heap block.
> +    // In this case, the m_data pointer is an "internal buffer", and does
not need to be deallocated.
> +    bool bufferIsInternal() { return m_data == &m_buffer[0]; }

I realized you can write this as m_data == m_buffer without the &[0] part.

r=me