[webkit-reviews] review granted: [Bug 30021] check-webkit-style does not detect missing spaces around &=, |=, -=, and += : [Attachment 40548] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 4 14:02:00 PDT 2009


David Levin <levin at chromium.org> has granted Carol Szabo
<carol.szabo at nokia.com>'s request for review:
Bug 30021: check-webkit-style does not detect missing spaces around &=, |=, -=,
and +=
https://bugs.webkit.org/show_bug.cgi?id=30021

Attachment 40548: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=40548&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Looks good.  Thanks for making it better!

btw, about the allowed items that shouldn't be allowed, check-webkit-style is a
recent addition to WebKit and thus may be more liberal than desired (due to its
heritage from checking Google style).


More information about the webkit-reviews mailing list