[webkit-reviews] review requested: [Bug 30061] [Gtk][Layout tests] Generate results for editing tests : [Attachment 40598] Generated results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 4 11:37:02 PDT 2009


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 30061: [Gtk][Layout tests] Generate results for editing tests
https://bugs.webkit.org/show_bug.cgi?id=30061

Attachment 40598: Generated results
https://bugs.webkit.org/attachment.cgi?id=40598&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This patch adds generated test results for about 350 tests. Only these tests
produce 'rendering-equal' results to those from the mac port.

With 'rendering-equal' phrase, these guarantees are meant:
- Equal render objects are created in the same places (not necessarrily in the
exact same position and with exact same size)
- These objects have equal CSS attributes (borders, color etc.)
- In the case of text runs, they contain equal text
- Equal caret and selection attributes dump
Basically, they're semantically equal, there can be differences in the size and
position of render objects because of different font metrics.

Tests that do not produce 'rendering-equal' results should be listed in another
bug, examined and then fixed if fixable or added as generated if they're not
fixable and acceptable as such.


More information about the webkit-reviews mailing list